linux-kernel - Re: [PATCH 0/8] ftrace: updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Jul 2008 16:47:25 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] ftrace: updates


* Ingo Molnar <mingo@...e.hu> wrote:

> * Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > Working on the ftrace.txt file proved to show some bugs with ftrace. 
> > These are a list of patches that I have accumulated for ftrace that 
> > solve those bugs (as well as other things).
> 
> applied them to tip/tracing/ftrace:
> 
>  Steven Rostedt (8):
>       ftrace: move sched_switch enable after markers
>       ftrace: define function trace nop
>       ftrace: trace schedule
>       ftrace: check proper config for preempt type
>       ftrace: start wakeup tracing after setting function tracer
>       ftrace: use current CPU for function startup
>       ftrace: add ftrace_kill_atomic
>       ftrace: separate out the function enabled variable

found a build bug in testing - find the fix below.

	Ingo

-------------->
commit b2613e370dbeb69edbff989382fa54f2395aa471
Author: Ingo Molnar <mingo@...e.hu>
Date:   Fri Jul 11 16:44:27 2008 +0200

    ftrace: build fix for ftraced_suspend
    
    fix:
    
     kernel/trace/ftrace.c:1615: error: 'ftraced_suspend' undeclared (first use in this function)
     kernel/trace/ftrace.c:1615: error: (Each undeclared identifier is reported only once
     kernel/trace/ftrace.c:1615: error: for each function it appears in.)
    
    Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 kernel/trace/ftrace.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 1359632..4231a3d 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -1612,7 +1612,9 @@ void ftrace_kill_atomic(void)
 {
 	ftrace_disabled = 1;
 	ftrace_enabled = 0;
+#ifdef CONFIG_DYNAMIC_FTRACE
 	ftraced_suspend = -1;
+#endif
 	clear_ftrace_function();
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/