| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200807111705.49840.rjw@sisk.pl> Date: Fri, 11 Jul 2008 17:05:49 +0200 From: "Rafael J. Wysocki" <rjw@...k.pl> To: David Howells <dhowells@...hat.com> Cc: akpm@...ux-foundation.org, pavel@....cz, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Fix try_to_freeze_tasks()'s use of do_div() On Friday, 11 of July 2008, David Howells wrote: > Fix try_to_freeze_tasks()'s use of do_div() on an s64 by making elapsed_csecs64 > a u64 instead and dividing that. > > Possibly this should be guarded lest the interval calculation turn up negative, > but the possible negativity of the result of the division is cast away anyway. > > This was introduced by patch 438e2ce68dfd4af4cfcec2f873564fb921db4bb5. > > Signed-off-by: David Howells <dhowells@...hat.com> Acked-by: Rafael J. Wysocki <rjw@...k.pl> > --- > > kernel/power/process.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > diff --git a/kernel/power/process.c b/kernel/power/process.c > index 5fb8765..278946a 100644 > --- a/kernel/power/process.c > +++ b/kernel/power/process.c > @@ -149,7 +149,7 @@ static int try_to_freeze_tasks(bool sig_only) > unsigned long end_time; > unsigned int todo; > struct timeval start, end; > - s64 elapsed_csecs64; > + u64 elapsed_csecs64; > unsigned int elapsed_csecs; > > do_gettimeofday(&start); > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists