linux-kernel - Re: + use-warn-in-fs-proc.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080711195305.GA29379@martell.zuzino.mipt.ru>
Date:	Fri, 11 Jul 2008 23:53:05 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	arjan@...ux.intel.com, akpm@...l.org
Subject: Re: + use-warn-in-fs-proc.patch added to -mm tree

On Fri, Jul 11, 2008 at 11:45:40AM -0700, akpm@...ux-foundation.org wrote:
> --- a/fs/proc/generic.c~use-warn-in-fs-proc
> +++ a/fs/proc/generic.c
> @@ -806,12 +806,9 @@ continue_removing:
>  	if (S_ISDIR(de->mode))
>  		parent->nlink--;
>  	de->nlink = 0;
> -	if (de->subdir) {
> -		printk(KERN_WARNING "%s: removing non-empty directory "
> +	WARN(de->subdir, KERN_WARNING "%s: removing non-empty directory "
>  			"'%s/%s', leaking at least '%s'\n", __func__,
>  			de->parent->name, de->name, de->subdir->name);
> -		WARN_ON(1);
> -	}

It would be nice to call it WARN_IF but OK anyway.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/