linux-kernel - Re: [PATCH resend] ov7670: clean up ov7670

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080711184222.5403dca9@fred>
Date:	Fri, 11 Jul 2008 18:42:22 -0400
From:	Andres Salomon <dilinger@...ued.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Cortland Setlow <csetlow@...er-research.com>, corbet@....net,
	video4linux-list@...hat.com,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: [PATCH resend] ov7670: clean up ov7670_read semantics

On Fri, 11 Jul 2008 15:19:19 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Fri, 11 Jul 2008 16:52:16 -0400 Andres Salomon
> <dilinger@...ued.net> wrote:
> 
> > [note: this should probably go in for 2.6.26, as it fixes a bug in
> > ov7670_s_fmt where we incorrectly think that we've failed because we
> > return !0]
> > 
> 
> In which case 2.6.25.x wants the fix as well?
> 

Yep!

[...]
> > diff --git a/drivers/media/video/ov7670.c
> > b/drivers/media/video/ov7670.c index 2bc6bdc..d7bfd30 100644
> > --- a/drivers/media/video/ov7670.c
> > +++ b/drivers/media/video/ov7670.c
> > @@ -406,8 +406,10 @@ static int ov7670_read(struct i2c_client *c,
> > unsigned char reg, int ret;
> 
> You have some wordwrapping happening there.
> 

Eek, thanks.  The original send wasn't line-wrapped, I'm not sure how
that happened.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/