linux-kernel - Re: [PATCH] x86_64: fix delayed signals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0807101824150.2936@woody.linux-foundation.org>
Date:	Thu, 10 Jul 2008 18:48:16 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Roland McGrath <roland@...hat.com>
cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86_64: fix delayed signals

On Thu, 10 Jul 2008, Roland McGrath wrote:
> 
> i386 has never behaved this way, and still doesn't.

Btw, I told you differently, you didn't believe me. So I went back just 
because I have an ego easily the size of Manhattan, and when you doubt me, 
my ego is hurt.

i386 _has_ very much behaved this way. The system call code literally used 
to do

		..
	        cmpl $0,sigpending(%ebx)
	        jne signal_return
		..

and then 'signal_return' case would handle one signal and then return to 
user space:

		..
	        call SYMBOL_NAME(do_signal)
	#ifdef CONFIG_SMP
	        GET_CURRENT(%ebx)
	#endif
	        cli
	        CHECK_SOFTIRQ
	        je restore_all
		..

ie it would call "restore_all" without re-checking signals. I wasn't 
hallucinating.

So that's really old code.

The _really_ ancient code (like a decade ago or more) used to actually 
loop in do_signal() generating multiple signal stacks in one go. Then, a 
long long time ago, that was actually removed, and we expressly only tried 
to queue one signal at a time. I do not remember why, but it was before 
2.4.0. Probably _long_ before, but it's so long ago my memory is 
unreliable.

The "queue multiple signals" code that you claim has always been there is 
in fact pretty recent. For x86-32, it was a thing introduced in commit 
c3ff8ec31c1249d268cd11390649768a12bec1b9: by _you_, just three years ago, 
in 2.6.14, in regular git times.

So the x86-64 behaviour actually matches what the x86-32 behavior was at 
the time before things split.

And I'd also like to point out another commit, namely "[PATCH] fix broken 
vm86 interrupt/signal handling" (4031ff388138b58e5cd472dccce38828bcb8c706) 
that fixed a bug with an endless loop you had introduced in that original 
x86-32 code when you fixed this exact same issue back when.

Heh. That's the kind of thing that worries me.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/