linux-kernel - Re: [patch 1/4] firewire: fix race of bus reset with request transmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tkrat.c946d53f67bae7d5@s5r6.in-berlin.de>
Date:	Sat, 12 Jul 2008 14:59:44 +0200 (CEST)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux1394-devel@...ts.sourceforge.net
cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch 1/4] firewire: fix race of bus reset with request
 transmission

I wrote:
> Contexts which access an instance of struct fw_transaction are:
>  1. the submitter, until it inserted the packet which is embedded in the
>     transaction into the AT req DMA,
>  2. the AsReqTrContext tasklet when the request packet was acked by the
>     responder node or transmission to the responder failed,
>  3. the AsRspRcvContext tasklet when it found a request which matched
>     an incoming response,
>  4. the card->flush_timer when it picks up timed-out transactions to
>     cancel them,
>  5. the bus reset tasklet when it cancels transactions (this access is
>     eliminated by this patch),
>  6. a process which shuts down an fw_card (unregisters it from fw-core
>     when the controller is unbound from fw-ohci) --- although in this
>     case there shouldn't really be any transactions anymore because we
>     wait until all card users finished their business with the card.
> 
> All of these contexts run concurrently (except for the 6th, presumably).

PS:  Actually the three tasklets (2nd, 3rd, 5th context) are all
scheduled on the same CPU, hence are serialized.  Therefore

> The 5th looks safe against 2nd, 3rd [...] but is unsafe against 1st.

5th is serialized against 4th and 6th by lock protection of
card->transaction_list accesses.
-- 
Stefan Richter
-=====-==--- -=== -==--
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/