linux-kernel - Re: [RFT] x86 acpi: normalize segment descriptor register on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <487A2431.2050103@myrealbox.com>
Date:	Sun, 13 Jul 2008 11:50:09 -0400
From:	Andy Lutomirski <luto@...ealbox.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
CC:	Ingo Molnar <mingo@...e.hu>, "Rafael J. Wysocki" <rjw@...k.pl>,
	"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <andi@...stfloor.org>,
	public-kernel-testers-u79uwXL29TY76Z2rM5mHXA@...gmane.org,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	Pavel Machek <pavel@....cz>
Subject: Re: [RFT] x86 acpi: normalize segment descriptor register on resume

Matthew Garrett wrote:
> On Sun, Jul 13, 2008 at 11:15:24AM +0200, Ingo Molnar wrote:
> 
>> we still need to find the HAL quirk and disable it, right?
> 
> Not without understanding what the cause is. If the video BIOS calls are 
> generically broken, then we have a problem.
> 

The HAL quirk is the very first one here:

http://gitweb.freedesktop.org/?p=hal-info.git;a=blob;f=fdi/information/10freedesktop/20-video-quirk-pm-lenovo.fdi

I removed it from the HAL config and suspending w/ the hardware button 
works fine now with -rc9-wl and on Ubuntu's stock .24 kernel.

I'll file the obvious bug report against HAL, but it might annoy users 
if new kernel + old HAL = broken system, when the old kernel worked 
fine.  An alternative might be to make the change in 4b4f7280 
conditional on a new acpi_video_flags quirk so that previously-working 
systems keep working.

The quirk that actually breaks is s3_bios.  s3_mode still works, and 
power/video.txt says:

(2) systems where it is possible to call the video BIOS during S3
   resume. Unfortunately, it is not correct to call the video BIOS at
   that point, but it happens to work on some machines. Use
   acpi_sleep=s3_bios.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/