linux-kernel - Re: current linux-2.6.git: cpusets completely broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080713174252.GA13115@elte.hu>
Date:	Sun, 13 Jul 2008 19:42:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Dmitry Adamushko <dmitry.adamushko@...il.com>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Paul Menage <menage@...gle.com>,
	Max Krasnyansky <maxk@...lcomm.com>, Paul Jackson <pj@....com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>, miaox@...fujitsu.com,
	rostedt@...dmis.org, Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: current linux-2.6.git: cpusets completely broken

* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> The thing is, we should fix the top level code to never even 
> _consider_ an invalid CPU as a target, and that in turn should mean 
> that all the other code should be able to just totally ignore CPU 
> hotplug events.

agreed. We thought we could get away by hiding the "is the CPU dead" 
information in existing data structures (by shaping sched domains to 
never lead to a dead CPU) - but this method has proven itself fragile 
via a series of bugs.

It was one micro-optimization one too many. We should just accept the 
fact that the current model is not maintainable and add your extra (and 
trivial) cpu_active_map layer that protects against migrating to CPUs 
that are going down. [we'll basically introduce a "going down" state 
inbetween 'online' and 'offline']

And this will get rid of some other fragile trickery - because from that 
point on we dont have to be super-careful about the whole sequence of 
manipulating sched domains anymore. Cpusets can do whatever it wants, it 
wont be able to break hotplug+scheduling - and that's important for any 
functionality that is not used by default.

[ I dont think Dmitry will disagree with this notion all that much, it's
  just that his personal limit for calling an algorithm unmaintainable
  is probably a lot higher than normal :-) ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/