linux-kernel - Re: [PATCH 1/3] genclk: add generic framework for managing clocks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080713140352.5d81614c.akpm@linux-foundation.org>
Date:	Sun, 13 Jul 2008 14:03:52 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Dmitry <dbaryshkov@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	"Haavard Skinnemoen" <haavard.skinnemoen@...el.com>,
	"Russell King" <rmk+lkml@....linux.org.uk>,
	"Paul Mundt" <lethal@...ux-sh.org>,
	"pHilipp Zabel" <philipp.zabel@...il.com>,
	"Pavel Machek" <pavel@....cz>, tony@...mide.com, paul@...an.com,
	"David Brownell" <david-b@...bell.net>,
	"Mark Brown" <broonie@...nsource.wolfsonmicro.com>,
	ian <spyro@....com>
Subject: Re: [PATCH 1/3] genclk: add generic framework for managing clocks.

On Mon, 14 Jul 2008 00:53:51 +0400 Dmitry <dbaryshkov@...il.com> wrote:

> >  > +     list_del(&clk->priv.node);
> >  > +     kref_put(&clk->priv.ref, clk_release);
> >
> >
> > Might not be able to call kref_put(), either.
> 
> I'll move it outside of the spinlock. But tell me please, why?

Because the release handler might not like being called under
that lock.  I didn't check...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/