linux-kernel - Re: [mmotm] pm: fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080714073414.GB1796@elf.ucw.cz>
Date:	Mon, 14 Jul 2008 09:34:14 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Zhang Rui <rui.zhang@...el.com>, Rus <harbour@...nx.od.ua>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [mmotm] pm: fix build error

Hi!

> My IA64 machine can't build on today's mmotm(Jul 13).
> So, below patch is necessary, I think.
> 
> ----------------------------------------------------
> Against: mmotm, Jul 13
> Applies after: pm-schedule-sysrq-poweroff-on-boot-cpu.patch
> 
> Now, handle_poweroff() use cpu_online_map variable.
> So cpumask.h sould be included.
> Otherwise it cause following build error on ia64 (I guess also sevaral othor platfom).
> 
> 	kernel/power/poweroff.c: In function 'handle_poweroff':
> 	kernel/power/poweroff.c:29: error: implicit declaration of function 'first_cpu'
> 	kernel/power/poweroff.c:29: error: 'cpu_online_map' undeclared (first use in this function)
> 	kernel/power/poweroff.c:29: error: (Each undeclared identifier is reported only once
> 	kernel/power/poweroff.c:29: error: for each function it appears in.)
> 	make[2]: *** [kernel/power/poweroff.o] Error 1
> 	make[1]: *** [kernel/power] Error 2
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> CC: Zhang Rui <rui.zhang@...el.com>
> CC: Rus <harbour@...nx.od.ua>
> CC: Rafael J. Wysocki <rjw@...k.pl>
> CC: Pavel Machek <pavel@....cz>

ACK.

> ---
>  kernel/power/poweroff.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: b/kernel/power/poweroff.c
> ===================================================================
> --- a/kernel/power/poweroff.c
> +++ b/kernel/power/poweroff.c
> @@ -10,6 +10,7 @@
>  #include <linux/pm.h>
>  #include <linux/workqueue.h>
>  #include <linux/reboot.h>
> +#include <linux/cpumask.h>
>  
>  /*
>   * When the user hits Sys-Rq o to power down the machine this is the
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/