linux-kernel - Re: [PATCH 1/1] LCD backlight driver using Atmel PWM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Jul 2008 09:11:02 +0200
From:	Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] LCD backlight driver using Atmel PWM driver

On Fri, 2008-07-11 at 12:17 -0700, Andrew Morton wrote:
> On Wed,  9 Jul 2008 15:08:06 +0200 Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com> wrote:
> 
> > +	if (bd->props.power != FB_BLANK_UNBLANK)
> > +		intensity = 0;
> > +	if (bd->props.fb_blank != FB_BLANK_UNBLANK)
> > +		intensity = 0;
> 
> hm, is that correct?  It is strange that two different fields can validly
> be compared with the same enumeration like this.
> 

I also found it a bit weird having two fields indicating the same, but
the header file has the following documentation:

/* Current FB Power mode (0: full on, 1..3: power saving
   modes; 4: full off), see FB_BLANK_XXX */
int power;
/* FB Blanking active? (values as for power) */
int fb_blank;

So, AFAIK, my assumptions are correct to get proper blanking?

-- 
With kind regards,
Hans-Christian Egtvedt, Applications Engineer

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/