linux-kernel - Re: [PATCH] qla1280: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <487B1C73.5000202@sgi.com>
Date:	Mon, 14 Jul 2008 11:29:23 +0200
From:	Jes Sorensen <jes@....com>
To:	Jaswinder Singh <jaswinder@...radead.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	kernel-janitors <kernel-janitors@...r.kernel.org>,
	kernelnewbies <kernelnewbies@...linux.org>,
	linux-scsi@...r.kernel.org, hch@...radead.org
Subject: Re: [PATCH] qla1280: use request_firmware

Jaswinder Singh wrote:
> this is a first draft; please be kind :)
> 
> Firmware blob is little endian looks like this...
> 	unsigned char  Version1
> 	unsigned char  Version2
> 	unsigned char  Version3
> 	unsigned char  Padding
> 	unsigned short start_address
> 	unsigned short data

Hello,

As the maintainer of this driver I am going to say that I think this is
a stupid change. Yes I know that politically there's a move to make
everything use request firmware. However for my boot device, this is
going to be a royal pain in the butt for developers who wish to boot
test kernels with a / sitting on a 1280.

IMHO this patch brings us nothing, but provides a lot of unnecessary
hassle for users.

Nacked-By: Jes Sorensen <jes@....com>

Regards,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/