linux-kernel - [mmotm] kill devcgroup-code-cleanup.patch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 14 Jul 2008 19:54:35 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Li Zefan <lizf@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	kosaki.motohiro@...fujitsu.com
Subject: [mmotm] kill devcgroup-code-cleanup.patch warning 

Patch titile: devcgroup-code-cleanup-fix-fix.patch
Patch against: mmotm Jul 13
Applies after: devcgroup-code-cleanup-fix.patch

devcgroup-code-cleanup.patch made following warnings because b is const.

  security/device_cgroup.c: In function 'devcgroup_update_access':
  security/device_cgroup.c:397: warning: passing argument 2 of 'simple_strtoul' from incompatible pointer type
  security/device_cgroup.c:410: warning: passing argument 2 of 'simple_strtoul' from incompatible pointer type

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
CC: Li Zefan <lizf@...fujitsu.com>

---
 security/device_cgroup.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: b/security/device_cgroup.c
===================================================================
--- a/security/device_cgroup.c
+++ b/security/device_cgroup.c
@@ -359,6 +359,7 @@ static int devcgroup_update_access(struc
 {
 	struct dev_cgroup *cur_devcgroup;
 	const char *b;
+	char *endp;
 	int retval = 0, count;
 	struct dev_whitelist_item wh;
 
@@ -394,7 +395,8 @@ static int devcgroup_update_access(struc
 		wh.major = ~0;
 		b++;
 	} else if (isdigit(*b)) {
-		wh.major = simple_strtoul(b, &b, 10);
+		wh.major = simple_strtoul(b, &endp, 10);
+		b = endp;
 	} else {
 		return -EINVAL;
 	}
@@ -407,7 +409,8 @@ static int devcgroup_update_access(struc
 		wh.minor = ~0;
 		b++;
 	} else if (isdigit(*b)) {
-		wh.minor = simple_strtoul(b, &b, 10);
+		wh.minor = simple_strtoul(b, &endp, 10);
+		b = endp;
 	} else {
 		return -EINVAL;
 	}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/