[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080714143357.2d6cfc91@the-village.bc.nu>
Date: Mon, 14 Jul 2008 14:33:57 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Akinobu Mita <akinobu.mita@...il.com>
Cc: linux-kernel@...r.kernel.org,
"Michael H. Warfield" <mhw@...tsend.com>
Subject: Re: [PATCH] ip2: avoid add_timer() with pending timer
On Mon, 14 Jul 2008 11:49:55 +0900
Akinobu Mita <akinobu.mita@...il.com> wrote:
> add_timer() is not suppose to be called when the timer is pending.
> ip2 driver attempts to avoid that condition by setting and resetting
> a flag (TimerOn) in timer function. But there is some gap between
> add_timer() and setting TimerOn.
>
> This patch fix this problem by using mod_timer() and remove TimerOn
> which has been unnecessary by this change.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Michael H. Warfield <mhw@...tsend.com>
Acked-by: Alan Cox <alan@...hat.com>
Queued for ttydev tree
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists