linux-kernel - Re: [PATCH] - GRU virtual -> physical translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080714092451.2c81a472.akpm@linux-foundation.org>
Date:	Mon, 14 Jul 2008 09:24:51 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jack Steiner <steiner@....com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] - GRU virtual -> physical translation

On Mon, 14 Jul 2008 09:52:55 -0500 Jack Steiner <steiner@....com> wrote:

> On Fri, Jul 11, 2008 at 12:17:36PM -0700, Andrew Morton wrote:
> > On Wed, 9 Jul 2008 14:14:39 -0500 Jack Steiner <steiner@....com> wrote:
> > 
> > > Open code the equivalent to follow_page(). This eliminates the
> > > requirement for an EXPORT of follow_page().
> > 
> > I'd prefer to export follow_page() - copying-n-pasting just to avoid
> > exporting the darn thing is silly.
> 
> If follow_page() can be EXPORTed, I think that may make the most sense for
> now.

What was Christoph's reason for objecting to the export?

> > 
> > > In addition, the code
> > > is optimized for the specific case that is needed by the GRU and only
> > > supports architectures supported by the GRU (ia64 & x86_64).
> > 
> > Unless you think that this alone justifies the patch?
> 
> No, at least not now. We don't have enough data yet to know if the additional
> performance is worth having an optimized lookup routine. Currently the
> focus is in making the driver functionally correct. Performance optimization
> will be done later when we have a better understanding of the user apps that
> will use the GRU.
> 
> _IF_ we agree to the export, what is the best way to send you the patches.
> Incremental or an entirely new GRU V3 patch with all issues resolved?

Incremental would be preferred, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/