linux-kernel - Re: [RESEND PATCH] kmemtrace: SLAB hooks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216059588.6762.20.camel@penberg-laptop>
Date:	Mon, 14 Jul 2008 21:19:48 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Cc:	cl@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [RESEND PATCH] kmemtrace: SLAB hooks.

Hi Eduard-Gabriel,

On Mon, 2008-07-14 at 20:42 +0300, Eduard - Gabriel Munteanu wrote:
> This adds hooks for the SLAB allocator, to allow tracing with
> kmemtrace.
> 
> Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
> @@ -28,8 +29,20 @@ extern struct cache_sizes malloc_sizes[];
>  void *kmem_cache_alloc(struct kmem_cache *, gfp_t);
>  void *__kmalloc(size_t size, gfp_t flags);
>  
> +#ifdef CONFIG_KMEMTRACE
> +extern void *__kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags);
> +#else
> +static inline void *__kmem_cache_alloc(struct kmem_cache *cachep,
> +				       gfp_t flags)
> +{
> +	return kmem_cache_alloc(cachep, flags);
> +}
> +#endif
> +

I'm okay with this approach but then you need to do
s/__kmem_cache_alloc/kmem_cache_alloc_trace/ or similar. In the kernel,
it's always the *upper* level function that doesn't have the
underscores.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/