linux-kernel - Re: [PATCH] Fix pci_subsys_init() to have a return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807141421.03305.jbarnes@virtuousgeek.org>
Date:	Mon, 14 Jul 2008 14:21:03 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	David Howells <dhowells@...hat.com>
Cc:	akpm@...ux-foundation.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix pci_subsys_init() to have a return value

On Friday, July 11, 2008 2:46 am David Howells wrote:
> Fix pci_subsys_init() to return a value (0) when it has finished.  All the
> functions it calls currently return 0, so returning 0 here unconditionally
> rather than gathering the results of its callees would seem reasonable.
>
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
>
>  arch/x86/pci/legacy.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
> index 3c1d795..00e29c8 100644
> --- a/arch/x86/pci/legacy.c
> +++ b/arch/x86/pci/legacy.c
> @@ -63,5 +63,6 @@ int __init pci_subsys_init(void)
>  	pci_legacy_init();
>  	pcibios_irq_init();
>  	pcibios_init();
> +	return 0;
>  }
>  subsys_initcall(pci_subsys_init);

Looks like Robert already pushed a patch like this via the x86 tree, but at 
least it's been fixed.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/