linux-kernel - Re: x86: PCI multi domain/segment config access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200807141428.11022.jbarnes@virtuousgeek.org>
Date:	Mon, 14 Jul 2008 14:28:10 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Matthew Wilcox <matthew@....cx>
Cc:	John Keller <jpk@....com>, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: x86: PCI multi domain/segment config access

On Friday, July 11, 2008 2:21 pm Matthew Wilcox wrote:
> On Fri, Jul 11, 2008 at 04:13:47PM -0500, John Keller wrote:
> > On x86 PCI Config space access to domains/segments > 0 appears to be
> > broken. The noted patch related to PCI ext config space has all config
> > accesses to offsets < 256 using conf1 if available, which is most likely
> > the case.
> >
> > This would force usage of conf1 for non-extended config access (< 256) on
> > PCI domains > 0.
> >
> > Am I missing something, or how would a conf1 access reference a domain
> > other than zero?
>
> You're correct.  Sorry about that, I wasn't thinking about domains at
> the time I wrote the patch.  Try this:
>
> [X86] Fix PCI config space for domains > 0
>
> John Keller reports that PCI config space access is broken on machines
> with more than one domain.  conf1 accesses only work for domain 0.
>
> Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>

Oops, yeah, good catch.  Thanks for fixing this up, Matthew.  Just applied it 
to my linux-next branch.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/