linux-kernel - Re: BUG: unable to handle kernel NULL pointer dereference at 000000000000000e (reset_prng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080715113304.GA30565@elte.hu>
Date:	Tue, 15 Jul 2008 13:33:04 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Neil Horman <nhorman@...driver.com>
Cc:	Simon Arlott <simon@...e.lp0.eu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: BUG: unable to handle kernel NULL pointer dereference at
	000000000000000e (reset_prng_context)


* Neil Horman <nhorman@...driver.com> wrote:

> On Tue, Jul 15, 2008 at 12:25:37AM +0100, Simon Arlott wrote:
> > http://img182.imageshack.us/img182/7205/1005489hh6.jpg
> > 
> > .config attached
> > 
> > -- 
> > Simon Arlott
> 
> Looks like you don't have rfc3686(ctr(aes)) compiled in.  Add 
> CONFIG_CRYPTO_CTR to your config, IIRC.  I'll add a depends directive 
> to Kconfig for that in my next update.

i have just triggered this crash too. Please, when you know about bootup 
crashes in your code send a patch to the lkml thread so that people can 
apply it and have a working system.

Note that the new crypto/prng.c driver has very bad quality:

  total: 45 errors, 21 warnings, 1 checks, 410 lines checked

It has tons of completely unacceptable code mistakes in it.

And the commit log says:

|  commit b8454eebe380677789735fd6bad368af2e6b2d1e
|  Author: Neil Horman <nhorman@...driver.com>
|  AuthorDate: Mon Jul 7 22:41:31 2008 +0800
|  CommitDate: Thu Jul 10 20:35:18 2008 +0800
|
|      crypto: prng - Deterministic CPRNG

i.e. this patch went in just 7 days from development to upstream, with 
insufficient review, with no linux-next presence at all (as of 
linux-next when v2.6.26 was released) and insufficient testing.

That's not how it's supposed to be.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/