linux-kernel - Re: [PATCH] ALSA Au1xpsc: psc not disabled when TX is idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080715130429.GC27297@roarinelk.homelinux.net>
Date:	Tue, 15 Jul 2008 15:04:29 +0200
From:	Manuel Lauss <mano@...rinelk.homelinux.net>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]  ALSA Au1xpsc: psc not disabled when TX is idle

On Tue, Jul 15, 2008 at 02:44:24PM +0200, Roel Kluin wrote:
> Untested patch
> ---
> TX idleness isn't tested, but RX twice. PSC is not disabled when TX is idle
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/sound/soc/au1x/psc-i2s.c b/sound/soc/au1x/psc-i2s.c
> index ba4b5c1..9384702 100644
> --- a/sound/soc/au1x/psc-i2s.c
> +++ b/sound/soc/au1x/psc-i2s.c
> @@ -231,7 +231,7 @@ static int au1xpsc_i2s_stop(struct au1xpsc_audio_data *pscdata, int stype)
> 
>         /* if both TX and RX are idle, disable PSC */
>         stat = au_readl(I2S_STAT(pscdata));
> -       if (!(stat & (PSC_I2SSTAT_RB | PSC_I2SSTAT_RB))) {
> +       if (!(stat & (PSC_I2SSTAT_TB | PSC_I2SSTAT_RB))) {
>                 au_writel(0, I2S_CFG(pscdata));
>                 au_sync();
>                 au_writel(PSC_CTRL_SUSPEND, PSC_CTRL(pscdata));

Ah, stupid copy-paste error. Thanks!

Acked-by: Manuel Lauss <mano@...rinelk.homelinux.net>

-- 
 Manuel Lauss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/