| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1216145368.27455.318.camel@shinybook.infradead.org> Date: Tue, 15 Jul 2008 11:09:28 -0700 From: David Woodhouse <dwmw2@...radead.org> To: Oliver Neukum <oliver@...kum.org> Cc: david@...g.hm, Arjan van de Ven <arjan@...radead.org>, David Miller <davem@...emloft.net>, torvalds@...ux-foundation.org, rene.herman@...access.nl, akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk, linux-kernel@...r.kernel.org Subject: Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers. On Tue, 2008-07-15 at 18:52 +0200, Oliver Neukum wrote: > Am Dienstag 15 Juli 2008 16:40:54 schrieb David Woodhouse: > > On Tue, 2008-07-15 at 08:23 +0200, Oliver Neukum wrote: > > > Am Dienstag 15 Juli 2008 08:03:15 schrieb David Woodhouse: > > > > Mostly it follows the documented recommendation, since most of the > > > > touched drivers are USB drivers and you end up re-enumerating and > > > > starting from scratch on resume anyway. And the remainder are so old > > > > that they don't have suspend/resume support anyway. Remember, we're only > > > > really updating the older drivers; newer drivers tend to use > > > > request_firmware() already, and have done for years. > > > > > > As for USB that was before persistance. It now allows you to even > > > support a loss of power without reprobing, provided > > > > > > a) the devices does not change IDs > > > b) you have firmware around when reset_resume() is called > > > > c) the driver in question actually _has_ a reset_resume() method > > > > The old, unloved drivers which I've touched as part of this patch set > > did not. In general the newer, loved drivers use request_firmware() > > already. > > > > Generally we love all drivers and welcome new additions. > Which did you touch? I lost track. Ignoring the simple bits to make fw->data const? See http://git.infradead.org/users/dwmw2/firmware-2.6.git?a=shortlog&h=d71792ac or git-diff --stat 59890f74..d71792ac | grep -v firmware/ 21 drivers, mostly older USB drivers and including four sound drivers which were already using request_firmware() optionally. The HEAD of my tree contains a few more updates in drivers/scsi and drivers/net, but out of respect for Dave's and Jeff's objections I left those out of the pull request for now. Hopefully the noise will die down when the sky doesn't _actually_ fall on our heads, and we can merge the remaining changes into 2.6.28. drivers/atm/Makefile | 6 +- drivers/atm/ambassador.c | 140 +- drivers/atm/ambassador.h | 11 - drivers/atm/atmsar11.data | 2063 ----- drivers/atm/atmsar11.regions | 6 - drivers/atm/atmsar11.start | 4 - drivers/char/dsp56k.c | 84 +- drivers/char/ip2/fip_firm.h | 2149 ----- drivers/char/ip2/ip2base.c | 5 +- drivers/char/ip2/ip2main.c | 47 +- drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c | 16 +- .../media/dvb/ttusb-budget/dvb-ttusb-dspbootcode.h | 1644 ---- drivers/media/video/cpia2/cpia2_core.c | 46 +- drivers/media/video/cpia2/cpia2patch.h | 233 - drivers/media/video/dabfirmware.h | 1415 ---- drivers/media/video/dabusb.c | 44 +- drivers/media/video/usbvideo/vicam.c | 317 +- drivers/net/tokenring/smctr.c | 56 +- drivers/net/tokenring/smctr.h | 2 - drivers/net/tokenring/smctr_firmware.h | 978 --- drivers/net/usb/kaweth.c | 43 +- drivers/net/usb/kawethfw.h | 557 -- drivers/usb/misc/emi26.c | 96 +- drivers/usb/misc/emi26_fw.h | 5779 ------------- drivers/usb/misc/emi62.c | 130 +- drivers/usb/misc/emi62_fw_m.h | 8853 -------------------- drivers/usb/misc/emi62_fw_s.h | 8837 ------------------- drivers/usb/serial/Kconfig | 24 +- drivers/usb/serial/io_edgeport.c | 183 +- drivers/usb/serial/io_fw_boot.h | 556 -- drivers/usb/serial/io_fw_boot2.h | 546 -- drivers/usb/serial/io_fw_down.h | 1229 --- drivers/usb/serial/io_fw_down2.h | 1133 --- drivers/usb/serial/io_fw_down3.h | 847 -- drivers/usb/serial/io_ti.c | 73 +- drivers/usb/serial/keyspan.c | 78 +- drivers/usb/serial/keyspan.h | 84 - drivers/usb/serial/keyspan_mpr_fw.h | 286 - drivers/usb/serial/keyspan_pda.S | 1124 --- drivers/usb/serial/keyspan_pda.c | 51 +- drivers/usb/serial/keyspan_pda_fw.h | 99 - drivers/usb/serial/keyspan_usa18x_fw.h | 447 - drivers/usb/serial/keyspan_usa19_fw.h | 285 - drivers/usb/serial/keyspan_usa19qi_fw.h | 284 - drivers/usb/serial/keyspan_usa19qw_fw.h | 448 - drivers/usb/serial/keyspan_usa19w_fw.h | 446 - drivers/usb/serial/keyspan_usa28_fw.h | 466 - drivers/usb/serial/keyspan_usa28x_fw.h | 447 - drivers/usb/serial/keyspan_usa28xa_fw.h | 449 - drivers/usb/serial/keyspan_usa28xb_fw.h | 448 - drivers/usb/serial/keyspan_usa49w_fw.h | 464 - drivers/usb/serial/keyspan_usa49wlc_fw.h | 476 -- drivers/usb/serial/ti_fw_3410.h | 885 -- drivers/usb/serial/ti_fw_5052.h | 885 -- drivers/usb/serial/ti_usb_3410_5052.c | 40 +- drivers/usb/serial/whiteheat.c | 77 +- drivers/usb/serial/whiteheat_fw.h | 1669 ---- drivers/usb/serial/xircom_pgs.S | 1192 --- drivers/usb/serial/xircom_pgs_fw.h | 103 - sound/isa/Kconfig | 9 - sound/isa/sb/sb16_csp.c | 22 - sound/isa/sb/sb16_csp_codecs.h | 949 --- sound/pci/Kconfig | 30 - sound/pci/korg1212/korg1212-firmware.h | 987 --- sound/pci/korg1212/korg1212.c | 18 - sound/pci/maestro3.c | 171 - sound/pci/ymfpci/ymfpci_image.h | 1565 ---- sound/pci/ymfpci/ymfpci_main.c | 63 - -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists