linux-kernel - Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <487D0985.6080102@garzik.org>
Date:	Tue, 15 Jul 2008 16:33:09 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Marcel Holtmann <marcel@...tmann.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Frans Pop <elendil@...net.nl>, arjan@...radead.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT *] Allow request_firmware() to be satisfied from	in-kernel,
 use it in more drivers.

Marcel Holtmann wrote:
> I really don't see that problem here since request_firmware() has been
> around for so long now and so many drivers are using it nowadays that I
> don't see your point here on how it will break.

There is no fundamental breakage in the new request_firmware() system.

However, it is misleading to state

	what I'm doing here is nothing new. Most modern
	drivers use request_firmware() already.

because we are not talking about new drivers, we are talking about 
existing drivers changing en masse from "not requiring firmware" state 
to "requiring firmware" state.

We are also talking about a totally new source of critically important 
data (the firmware, coming from the kernel tree), and scripts must be 
updated to take that into account.

Sure, in many cases the fix may even be a one-liner...  but you still 
need that fix, in order to continue to use drivers that were working in 
2.6.26.

	Jeff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/