linux-kernel - Re: [PATCH] mm: fix build on non-mmu machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <487D0D43.2000003@goop.org>
Date:	Tue, 15 Jul 2008 13:49:07 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Sebastian Siewior <bigeasy@...utronix.de>
CC:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Hugh Dickins <hugh@...itas.com>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH] mm: fix build on non-mmu machines

Sebastian Siewior wrote:
> Commit 1ea0704e0d aka
>  [mm: add a ptep_modify_prot transaction abstraction]
>
> caused:
>
> |  CC      init/main.o
> |In file included from include2/asm/pgtable.h:68,
> |                 from /home/bigeasy/git/linux-2.6-m68k/include/linux/mm.h:39,
> |                 from include2/asm/uaccess.h:8,
> |                 from /home/bigeasy/git/linux-2.6-m68k/include/linux/poll.h:13,
> |                 from /home/bigeasy/git/linux-2.6-m68k/include/linux/rtc.h:113,
> |                 from /home/bigeasy/git/linux-2.6-m68k/include/linux/efi.h:19,
> |                 from /home/bigeasy/git/linux-2.6-m68k/init/main.c:43:
> |/linux-2.6/include/asm-generic/pgtable.h: In function '__ptep_modify_prot_start':
> |/linux-2.6/include/asm-generic/pgtable.h:209: error: implicit declaration of function 'ptep_get_and_clear'
> |/linux-2.6/include/asm-generic/pgtable.h:209: error: incompatible types in return
> |/linux-2.6/include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
> |/linux-2.6/include/asm-generic/pgtable.h:220: error: implicit declaration of function 'set_pte_at'
> |make[2]: *** [init/main.o] Error 1
> |make[1]: *** [init] Error 2
> |make: *** [sub-make] Error 2
>
> on my m68knommu box.
> Now I'm, not sure If this is the right solution, but with this
> patch applied I am able to boot the kernel I've build.
>   

I just posted an identical patch, so I'll take that as confirmation that 
it works ;)

Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/