linux-kernel - Re: [PATCH] mm: fix ptep_modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080716125231.GB25557@cs181140183.pp.htv.fi>
Date:	Wed, 16 Jul 2008 15:52:31 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Mike Frysinger <vapier.adi@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm: fix ptep_modify_* for no-MMU systems

On Tue, Jul 15, 2008 at 01:39:07PM -0700, Jeremy Fitzhardinge wrote:
> Fixes build problem: the functions added to asm-generic/pgtable.h are 
> only used by
> mm/mprotect.c (a MMU-only file), but they were not added inside of the
> CONFIG_MMU ifdef block.  since the functions rely on things inside of
> CONFIG_MMU (the lines just above in pgtable.h), we get build failure
> on all no-mmu setups:
>   CC      init/main.o
> In file included from include/asm/pgtable.h:94,
>                  from include/linux/mm.h:39,
>                  from include/asm/dma.h:39,
>                  from include/linux/bootmem.h:8,
>                  from init/main.c:27:
> include/asm-generic/pgtable.h: In function '__ptep_modify_prot_start':
> include/asm-generic/pgtable.h:210: error: implicit declaration of
> function 'ptep_get_and_clear'
> include/asm-generic/pgtable.h:210: error: incompatible types in return
> make[1]: *** [init/main.o] Error 1
> make: *** [init/main.o] Error 2
>...

Thanks, seems to work fine.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/