linux-kernel - Re: [build fix] Re: [GIT PATCH] SCSI part 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Jul 2008 16:46:02 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Matthew Wilcox <matthew@....cx>
Cc:	James Bottomley <James.Bottomley@...senPartnership.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [build fix] Re: [GIT PATCH] SCSI part 1


* Matthew Wilcox <matthew@....cx> wrote:

> On Wed, Jul 16, 2008 at 04:18:05PM +0200, Ingo Molnar wrote:
> > btw., about the technical aspects of the solution, i'm not sure i like 
> > these big #ifdef blocks:
> 
> It's partly the nature of the beast.  There's already several large
> #ifdef blocks in compat_ioctl.c -- CONFIG_NET, CONFIG_VT, 
> #CONFIG_SPARC, etc.  I think what would help is a bit more grouping so 
> #individual blocks get bigger.

yeah, that's OK - but why is scsi.h #ifdef-ed? For example we can 
include blkdev.h without #ifdef CONFIG_BLOCK.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/