[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080716150046.GI24546@Krystal>
Date: Wed, 16 Jul 2008 11:00:46 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To: Peter Zijlstra <peterz@...radead.org>
Cc: akpm@...ux-foundation.org, Ingo Molnar <mingo@...e.hu>,
linux-kernel@...r.kernel.org,
Masami Hiramatsu <mhiramat@...hat.com>, linux-mm@...ck.org,
Dave Hansen <haveblue@...ibm.com>,
"Frank Ch. Eigler" <fche@...hat.com>,
Hideo AOKI <haoki@...hat.com>,
Takashi Nishiie <t-nishiie@...css.fujitsu.com>,
Steven Rostedt <rostedt@...dmis.org>,
Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Subject: Re: [patch 10/17] LTTng instrumentation - swap
* Peter Zijlstra (peterz@...radead.org) wrote:
> On Wed, 2008-07-16 at 10:40 -0400, Mathieu Desnoyers wrote:
> > * Peter Zijlstra (peterz@...radead.org) wrote:
> > > On Tue, 2008-07-15 at 18:26 -0400, Mathieu Desnoyers wrote:
>
> > > > @@ -1796,6 +1799,7 @@ get_swap_info_struct(unsigned type)
> > > > {
> > > > return &swap_info[type];
> > > > }
> > > > +EXPORT_SYMBOL_GPL(get_swap_info_struct);
> > >
> > > I'm not too happy with this export.
> > >
> >
> > Would it make more sense to turn get_swap_info_struct into a static
> > inline in swap.h ?
>
> Seeing a consumer of it would go a long way towards discussing it ;-)
>
The LTTng probe which connects to this tracepoint looks like :
+static void probe_swap_out(struct page *page)
+{
+ trace_mark(mm_swap_out, "pfn %lu filp %p offset %lu",
+ page_to_pfn(page),
+ get_swap_info_struct(swp_type(
+ page_swp_entry(page)))->swap_file,
+ swp_offset(page_swp_entry(page)));
+}
So, I need get_swap_info_struct to extract the swap file pointer from
the swap entry.
Mathieu
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists