linux-kernel - Re: [PATCH] drivers/usb/class/usblp.c: adjust error handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807161744.59137.oliver@neukum.org>
Date:	Wed, 16 Jul 2008 17:44:58 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Julia Lawall <julia@...u.dk>
Cc:	zaitcev@...hat.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers/usb/class/usblp.c: adjust error handling code

Am Mittwoch 16 Juli 2008 17:17:42 schrieb Julia Lawall:
> From: Julia Lawall <julia@...u.dk>
> 
> In this code, it is possible to tell statically whether usblp will be NULL
> in the error handling code.
> 
> Another option would have been to put a label directly on the return.

That would be better. It means less chance to overlook an error case
if locking needs to be added in the future.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/