linux-kernel - Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adafxq9bxbr.fsf@cisco.com>
Date:	Wed, 16 Jul 2008 09:36:24 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Jie Yang <Jie.Yang@...eros.com>,
	"jeff\@garzik.org" <jeff@...zik.org>,
	David Miller <davem@...emloft.net>,
	"jcliburn\@gmail.com" <jcliburn@...il.com>,
	"parag.warudkar\@gmail.com" <parag.warudkar@...il.com>,
	Willy Tarreau <w@....eu>,
	"oliver.schuster\@schweigstill.de" <oliver.schuster@...weigstill.de>,
	"netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

 > Output of checkpatch (scripts/checkpatch.pl in kernel source).
 > Personally, I am not a whitespace bigot, and don't think
 > all the warnings in checkpatch have to be fixed.
 > 
 > ----------
 > ERROR: patch seems to be corrupt (line wrapped?)
 > #121: FILE: drivers/net/atl1e/atl1e.h:9:
 > ree
 > 
 > WARNING: space prohibited between function name and open parenthesis '('
 > #212: FILE: drivers/net/atl1e/atl1e.h:97:
 > +       _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\

It's kind of pointless to run checkpatch on a corrupted patch (the email
was quoted-printable and you didn't decode it back to text).  Of course
it's also better to send non-mangled patches.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/