[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <702673D5-9D36-4428-91FB-3D0697A1D5ED@kernel.crashing.org>
Date: Wed, 16 Jul 2008 17:01:28 -0500
From: Kumar Gala <galak@...nel.crashing.org>
To: Scott Wood <scottwood@...escale.com>
Cc: linuxppc-dev@...abs.org, davej@...hat.com,
akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
On Jul 16, 2008, at 4:47 PM, Scott Wood wrote:
> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
>> If we don't enable FS_ENET we get build issues:
>>
>> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to
>> `alloc_mdio_bitbang'
>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to
>> `mdiobus_register'
>
> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>
>> +#ifdef CONFIG_FS_ENET_MDIO_FCC
>> static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level)
>> {
>> if (level)
>> @@ -164,6 +165,7 @@ static struct of_platform_driver
>> ep8248e_mdio_driver = {
>> .probe = ep8248e_mdio_probe,
>> .remove = ep8248e_mdio_remove,
>> };
>> +#endif
>
> This is wrong -- ep8248e doesn't use the FS_ENET_MDIO_FCC code.
You're correct this should be CONFIG_MDIO_BITBANG
- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists