linux-kernel - Re: ACPI WARNING: at drivers/acpi/tables/tbfadt.c:348 acpi_tb_create_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8763r4yjfl.fsf@basil.nowhere.org>
Date:	Thu, 17 Jul 2008 11:00:14 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"Andrew Paprocki" <andrew@...iboo.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Jan Beulich" <jbeulich@...ell.com>,
	"Andi Kleen" <ak@...ux.intel.com>, "Len Brown" <lenb@...nel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>, robert.moore@...el.com
Subject: Re: ACPI WARNING: at drivers/acpi/tables/tbfadt.c:348 acpi_tb_create_local_fadt+0x147/0x2f4()

"Andrew Paprocki" <andrew@...iboo.com> writes:

[cc Bob More. What is your opinion?]

> This most definitely broke because of:
>
> commit 01a5bba576b9364b33f61f0cd9fa70c2cf5535e2
> Author: Jan Beulich <jbeulich@...ell.com>
> Date:   Wed Jul 16 23:27:08 2008 +0200
>
>     Fix FADT parsing
>
> I added printk()s and this is what is reported here:

Thanks for the detailed analysis. 


>
>         printk(KERN_INFO
>                "xpm1a_event_block bit_width=%d pm1_register_length=%d\n",
>                acpi_gbl_FADT.xpm1a_event_block.bit_width, pm1_register_length);
>         acpi_tb_init_generic_address(&acpi_gbl_xpm1a_enable,
>                                      pm1_register_length,
>                                      (acpi_gbl_FADT.xpm1a_event_block.address +
>                                       pm1_register_length));
>
> [    0.000000] xpm1a_event_block bit_width=8 pm1_register_length=0
>
> The bit width is not % 16, so the following patch addition a few lines
> earlier fails:
>
>         WARN_ON(ACPI_MOD_16(acpi_gbl_FADT.xpm1a_event_block.bit_width));

I'll queue a revert for now until this can be resolved properly.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/