linux-kernel - Re: SLUB: simplify re on_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2008 07:39:06 -0500
From:	Robin Holt <holt@....com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Robin Holt <holt@....com>, Alexey Dobriyan <adobriyan@...il.com>,
	cl@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: SLUB: simplify re on_each_cpu()

On Thu, Jul 17, 2008 at 03:26:46PM +0300, Pekka Enberg wrote:
> Hi Robin,
> 
> On Wed, Jul 16, 2008 at 09:29:02PM +0400, Alexey Dobriyan wrote:
> >> on_each_cpu() expands to function call on UP, too.
> 
> On Thu, Jul 17, 2008 at 2:38 PM, Robin Holt <holt@....com> wrote:
> > It looks to me like on_each_cpu is a #define for !SMP.  Are you certain
> > of the need for this change?  Are you looking at a different tree than
> > Linus'?
> 
> I think it's actually you who is looking at an older tree.

I did a git-checkout of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
which got me commit id 33af79d12e0fa25545d49e86afc67ea8ad5f2f40
and looked at include/linux/smp.h line 123.  It has:

#define on_each_cpu(func,info,wait)             \
        ({                                      \
                local_irq_disable();            \
                func(info);                     \
                local_irq_enable();             \
                0;                              \
        })

This is the !CONFIG_SMP case (line 111).  When I look at
kernel/softirq.c, I notice immediately prior to the comment the #ifdef
CONFIG_SMP.

They appear equivalent.  What am I missing?

Thanks,
Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/