lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 17 Jul 2008 09:40:03 -0400
From:	Josef Bacik <jbacik@...hat.com>
To:	Vegard Nossum <vegard.nossum@...il.com>
Cc:	Josef Bacik <josef@...icpanda.com>, linux-ext4@...r.kernel.org,
	sct@...hat.com, akpm@...ux-foundation.org, adilger@....com,
	Johannes Weiner <hannes@...urebad.de>,
	linux-kernel@...r.kernel.org
Subject: Re: ext3 on latest -git: BUG: unable to handle kernel NULL pointer
	dereference at 0000000c

On Thu, Jul 17, 2008 at 03:39:24PM +0200, Vegard Nossum wrote:
> On Thu, Jul 17, 2008 at 3:34 PM, Josef Bacik <josef@...icpanda.com> wrote:
> >> Yeah, the full log exists at
> >>
> >>    http://folk.uio.no/vegardno/linux/log-1216293934.txt
> >>
> >> I think this is the interesting part:
> >
> > Hmm well the journal should have aborted, but it looks like it didn't,
> > are you mounting with errors=continue by any chance?  Thanks much,
> 
> No, this is the command I used:
> 
>         mount -o loop disk mnt
> 
> I think this looks interesting:
> 
> EXT3-fs error (device loop0) in ext3_reserve_inode_write: IO failure
> 
> The code in ext3_reserve_inode_write() is here:
> 
>         err = ext3_journal_get_write_access(handle, iloc->bh);
>         if (err) {
>                 brelse(iloc->bh);
>                 iloc->bh = NULL;
>         }
> 
> Maybe it should do something different here?
> 
> But I don't know :-)
> 
> Thanks for helping out!
>

Well this is really odd, after that we call ext3_std_error which calls
journal_abort, so when we come into journal_dirty_metadata is_handle_aborted()
should have returned 1 and we should have just exited.  I'm going to have to
think on this for a bit.

Josef 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists