linux-kernel - Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080717105854.45427267@lappy.seanm.ca>
Date:	Thu, 17 Jul 2008 10:58:54 -0400
From:	Sean MacLennan <smaclennan@...atech.com>
To:	<avorontsov@...mvista.com>
Cc:	"Segher Boessenkool" <segher@...nel.crashing.org>,
	<linuxppc-dev@...abs.org>, "Richard Purdie" <rpurdie@...ys.net>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

On Thu, 17 Jul 2008 15:07:30 +0400
"Anton Vorontsov" <avorontsov@...mvista.com> wrote:

> This is tricky question. Personally I place them inside the gpio
> controller node that is responsible for the LED. But I think placing
> the led nodes at top level would be also fine (maybe with "leds { }"
> node as a parent for all board's LEDs. What would you suggest for a
> "best practice"?

I also put the leds under the gpio controller for the Warp. It is then
very clear which gpio controller the leds belong to.

Putting them at the top level does not associate the leds with the
correct gpio controller.

Warning: I am *not* using the of gpio led driver, but I hope to move to
it once the dust settles and drop the current Warp specific driver ;)

Cheers,
   Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/