linux-kernel - Re: [git patches] Ocfs2 and Configfs updates for 2.6.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080717212038.GA8283@ca-server1.us.oracle.com>
Date:	Thu, 17 Jul 2008 14:20:38 -0700
From:	Joel Becker <Joel.Becker@...cle.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Mark Fasheh <mfasheh@...e.com>, linux-kernel@...r.kernel.org,
	ocfs2-devel@....oracle.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [git patches] Ocfs2 and Configfs updates for 2.6.27

On Thu, Jul 17, 2008 at 11:01:40AM -0700, Linus Torvalds wrote:
> .. I really dislike how this was done.

	Argh!

> This commit:
> 
> 11c3b79218390a139f2d474ee1e983a672d5839a ("configfs: Allow ->make_item() 
> and ->make_group() to return detailed errors.")
> 
> is just ugly. Returning one value by passing a pointer to a pointer, and 
> the error value by returning an 'int' errno is _not_ how we do things in 
> the kernel.

	See, I coded it up with PTR_ERR() first, and everyone I showed
it to said "I hate PTR_ERR()!".

> I pulled it, but I want to register my protest.

	I wish you hadn't, because it won't be to difficult to go back
to PTR_ERR().  However, don't revert it - that affects some of the
follow-on patches that were affected by the change.
	I'll spin up a new PTR_ERR() change.  I have some more cleanups
coming too, they need to finish their time in linux-next.

Joel

-- 

"The cynics are right nine times out of ten."  
        - H. L. Mencken

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/