linux-kernel - RE: [PATCH] systemtap: fix up on_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60BA3EDE80604C4BAEE4AAF7FF714D185813FCF4@orsmsx504.amr.corp.intel.com>
Date:	Thu, 17 Jul 2008 16:00:39 -0700
From:	"Stone, Joshua I" <joshua.i.stone@...el.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>,
	"systemtap@...rceware.org" <systemtap@...rceware.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] systemtap: fix up on_each_cpu() for kernels 2.6.26+

James Bottomley wrote:
> In kernel 2.6.26, this patch
>
> commit 15c8b6c1aaaf1c4edd67e2f02e4d8e1bd1a51c0d
> Author: Jens Axboe <jens.axboe@...cle.com>
> Date:   Fri May 9 09:39:44 2008 +0200
>
>     on_each_cpu(): kill unused 'retry' parameter
>
> means that runtime/time.c is now using the wrong calling conventions.
> Fix this up and surround it by kernel versioning #ifdefs.

On a closer look, the referenced commit wasn't actually merged until
sometime between v2.6.26-git2 and -git3.  The released v2.6.26 still
has 'retry' in on_each_cpu(), so we'll either have to use an autoconf
test to detect the change, or wait and key the #ifdef on 2.6.27.

Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/