linux-kernel - Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2008 07:59:03 +0200
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	Anton Vorontsov <avorontsov@...mvista.com>
Cc:	Richard Purdie <rpurdie@...ys.net>, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: implement OpenFirmare GPIO LED driver

> diff --git a/Documentation/powerpc/dts-bindings/gpio/led.txt 
> b/Documentation/powerpc/dts-bindings/gpio/led.txt
> new file mode 100644
> index 0000000..7e9ce81
> --- /dev/null
> +++ b/Documentation/powerpc/dts-bindings/gpio/led.txt
> @@ -0,0 +1,15 @@
> +LED connected to GPIO
> +
> +Required properties:
> +- compatible : should be "gpio-led".

This "compatible" name is a bit too generic.  No, I don't know a
better name :-(

> +- label : (optional) the label for this LED. If omitted, the label is
> +  taken from the node name (excluding the unit address).

What is a label?  It should be described here.  Also, its encoding
should be described ("a string" I guess).

> +- gpios : should specify LED GPIO.
> +
> +Example:
> +
> +led@0 {
> +	compatible = "gpio-led";
> +	label = "hdd";
> +	gpios = <&mcu_pio 0 0>;
> +};

You show a unit address but have no "reg" value.  This is
incorrect.

What would be the parent node of this, btw?


Segher

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/