linux-kernel - Re: [git pull] PCI pull request for 2.6.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2008 01:23:50 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [git pull] PCI pull request for 2.6.27

On Wed, 16 Jul 2008, Jesse Barnes wrote:

> Yeah I noticed that too when I did the merge (and in the original patch), 
> though on my 80 char display it looked like a wash in terms of readability to 
> me, but even in that case I should have rejected it as noise.  Sorry about 
> that.

 Conveniently "for" is short enough for indentation like this:

	for (addr = (u8 *) __va(0xf0000);
	     addr < (u8 *) __va(0x100000);
	     addr += 16) {
                rt = pirq_check_routing_table(addr);

to make the piece of code both well-readable and polite to the right edge
of the terminal.  That would be my preference -- I hope you agree.

 Of course, in many cases it may be better to make use of auxiliary
variables instead.  GCC has to evaluate the expressions used anyway and
any names given to them come for free for any half-decent version of the
compiler.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/