linux-kernel - Re: [boot crash, bisected] in 9f240a55 "ALSA: opti93x: use cs4231 lib"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48806017.1040307@keyaccess.nl>
Date:	Fri, 18 Jul 2008 11:19:19 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Takashi Iwai <tiwai@...e.de>
CC:	Ingo Molnar <mingo@...e.hu>, Jaroslav Kysela <perex@...ex.cz>,
	LKML <linux-kernel@...r.kernel.org>,
	ALSA development <alsa-devel@...a-project.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Rene Herman <rene.herman@...il.com>,
	Krzysztof Helt <krzysztof.h1@...pl>
Subject: Re: [boot crash, bisected] in 9f240a55 "ALSA: opti93x: use cs4231
 lib"

On 17-07-08 21:38, Rene Herman wrote:

> On 17-07-08 21:20, Rene Herman wrote:
> 
>> On 17-07-08 20:40, Takashi Iwai wrote:
>>
>>> Could you try the patch below?
>>
>> No, please hang on, it's much simpler. Above commit isn't actually 
>> itself guilty. Have a patch ready, but am testing a bit.
> 
> I retract that. Your patch should fix things.

It does. Acked/Tested-by: Rene Herman <rene.herman@...il.com>

> I would like to place something on top to make the init isa/pnp choice 
> look more generic but I'll submit that tomorrow.

This bug was uncovered by !CONFIG_PNP and we had trouble in this driver 
due to that before so was rewriting the init to be a generic multi-card 
ALSA init but, actually, not much point.

The hardware fundamentally doesn't support more than one card per system 
due to the fixed chip->mc_base and the bug was in this case not _caused_ 
but only uncovered by !CONFIG_PNP (it triggers for CONFIG_PNP after 
supplying "isapnp=0" as a module param) so I'll just wait for the next 
time this ifdeffed together mess breaks on !CONFIG_PNP to make the init 
look generic ;-)

In fact, in the meantime I'll look at splitting 92x and 93x again. It's 
much better now that Krzysztof made it use the generic library code but 
I still hate this driver. It's also poking at ports without being told 
something is there by either system or user.

Trivial remainder of init rewrite that's still applicable:

Rene.


View attachment "0001-ALSA-opti9xx-no-isapnp-param-for-CONFIG_PNP.patch" of type "text/plain" (1648 bytes)