linux-kernel - Re: [PATCH] x86: APIC: Remove apic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080718105259.GY6875@elte.hu>
Date:	Fri, 18 Jul 2008 12:52:59 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Maciej W. Rozycki" <macro@...ux-mips.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>
Subject: Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives


* Maciej W. Rozycki <macro@...ux-mips.org> wrote:

>  Use alternatives to select the workaround for the 11AP Pentium 
> erratum for the affected steppings on the fly rather than build time.  
> Remove the X86_GOOD_APIC configuration option and replace all the 
> calls to apic_write_around() with plain apic_write(), protecting 
> accesses to the ESR as appropriate due to the 3AP Pentium erratum.  
> Remove apic_read_around() and all its invocations altogether as not 
> needed.  Remove apic_write_atomic() and all its implementing backends.  
> The use of ASM_OUTPUT2() is not strictly needed for input constraints, 
> but I have used it for readability's sake.

wow, impressive patch!

>  I had the feeling no one else was brave enough to do it, so I went 
> ahead and here it is.  Verified by checking the generated assembly and 
> tested with both a 32-bit and a 64-bit configuration, also with the 
> 11AP "feature" forced on and verified with gdb on /proc/kcore to work 
> as expected (as an 11AP machines are quite hard to get hands on these 
> days).  Some script complained about the use of "volatile", but 
> apic_write() needs it for the same reason and is effectively a 
> replacement for writel(), so I have disregarded it.

kudos for pulling this off :-)

applied to tip/x86/apic. This will interact with tip/x86/x2apic but that 
topic is being worked on anyway. The interaction should be trivial.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/