linux-kernel - Re: [PATCH] cpu hotplug: Make cpu_active_map synchronization dependency clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080718112635.GA6875@elte.hu>
Date:	Fri, 18 Jul 2008 13:26:35 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Max Krasnyansky <maxk@...lcomm.com>
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	dmitry.adamushko@...il.com, a.p.zijlstra@...llo.nl,
	rostedt@...dmis.org, vegard.nossum@...il.com
Subject: Re: [PATCH] cpu hotplug: Make cpu_active_map synchronization
	dependency clear


* Max Krasnyansky <maxk@...lcomm.com> wrote:

> This goes on top of the cpu_active_map (take 2) patch.

i've applied it to sched/devel. Note that checkpatch caught:

> +	/* Make sure the all cpus did the reschedule and are not
> +	 * using stale version of the cpu_active_map.
> +	 * This is not strictly necessary becuase stop_machine() 
> +	 * that we run down the line already provides the required 
> +	 * synchronization. But it's really a side effect and we do not 
> +	 * want to depend on the innards of the stop_machine here. */
> +	synchronize_sched();

this had both whitespace problems (trailing spaces) and basic formatting 
problems. I fixed these up.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/