linux-kernel - Re: [boot crash, bisected] in 9f240a55 "ALSA: opti93x: use cs4231 lib"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48808E39.4060404@keyaccess.nl>
Date:	Fri, 18 Jul 2008 14:36:09 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Krzysztof Helt <krzysztof.h1@...zta.fm>
CC:	Takashi Iwai <tiwai@...e.de>, Ingo Molnar <mingo@...e.hu>,
	Jaroslav Kysela <perex@...ex.cz>,
	LKML <linux-kernel@...r.kernel.org>,
	ALSA development <alsa-devel@...a-project.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Rene Herman <rene.herman@...il.com>,
	Krzysztof Helt <krzysztof.h1@...pl>
Subject: Re: [boot crash, bisected] in 9f240a55 "ALSA: opti93x: use cs4231
 lib"

On 18-07-08 14:28, Krzysztof Helt wrote:

> On Fri, 18 Jul 2008 11:19:19 +0200
> Rene Herman <rene.herman@...access.nl> wrote:
> 
>> On 17-07-08 21:38, Rene Herman wrote:
>>
>>> On 17-07-08 21:20, Rene Herman wrote:
>>>
>>>> On 17-07-08 20:40, Takashi Iwai wrote:
>>>>
>>>>> Could you try the patch below?
>> This bug was uncovered by !CONFIG_PNP and we had trouble in this driver 
>> due to that before so was rewriting the init to be a generic multi-card 
>> ALSA init but, actually, not much point.
>>
> 
> The bug was introduced by the patch as it used (tried to free) the codec pointer
> before it was assigned any value. It happened only if the card was missing and
> I didn't test the driver on such a configuration. My mistake. The CONFIG_PNP
> setting makes no difference.

Yes it does. Note how the ISA match method fails due to "if (isapnp)" 
with CONFIG_PNP and isapnp being initialized to 1. I did test without 
the hardware but didn't see it fail due to that.

>> In fact, in the meantime I'll look at splitting 92x and 93x again. It's 
>> much better now that Krzysztof made it use the generic library code but 
>> I still hate this driver. It's also poking at ports without being told 
>> something is there by either system or user.
>>
> 
> Please hold your axe until Monday. The last patch (not posted yet) from the 
> unification of the WSS library series removes some ifdefs in this driver.
> This may (or may not) change your view on splitting the driver.

Will do.

Rene.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/