linux-kernel - Re: kdump: Report actual value of VMCOREINFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080718140431.GE11492@redhat.com>
Date:	Fri, 18 Jul 2008 10:04:31 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Bernhard Walle <bwalle@...e.de>
Cc:	"Ken'ichi Ohmichi" <oomichi@....nes.nec.co.jp>,
	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org
Subject: Re: kdump: Report actual value of VMCOREINFO_OSRELEASE in
	VMCOREINFO

On Fri, Jul 18, 2008 at 12:07:45AM +0200, Bernhard Walle wrote:
> The current implementation reports the structure name as
> VMCOREINFO_OSRELEASE in VMCOREINFO, e.g.
> 
>         VMCOREINFO_OSRELEASE=init_uts_ns.name.release
> 
> That doesn't make sense because it's always the same. Instead, use the
> value, e.g.
> 
>         VMCOREINFO_OSRELEASE=2.6.26-rc3
> 
> That's also what the 'makedumpfile -g' does.
> 
> Signed-off-by: Bernhard Walle <bwalle@...e.de>
> 
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 3265968..3c7784d 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -127,8 +127,8 @@ void vmcoreinfo_append_str(const char *fmt, ...)
>  	__attribute__ ((format (printf, 1, 2)));
>  unsigned long paddr_vmcoreinfo_note(void);
>  
> -#define VMCOREINFO_OSRELEASE(name) \
> -	vmcoreinfo_append_str("OSRELEASE=%s\n", #name)
> +#define VMCOREINFO_OSRELEASE(value) \
> +	vmcoreinfo_append_str("OSRELEASE=%s\n", value)
>  #define VMCOREINFO_PAGESIZE(value) \
>  	vmcoreinfo_append_str("PAGESIZE=%ld\n", value)
>  #define VMCOREINFO_SYMBOL(name) \

Makes sense.

Acked-by: Vivek Goyal <vgoyal@...hat.com>

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/