[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e9c3a7c20807181116s49982f98p8d56a6e5e8264e6e@mail.gmail.com>
Date: Fri, 18 Jul 2008 11:16:38 -0700
From: "Dan Williams" <dan.j.williams@...el.com>
To: "Brice Goglin" <Brice.Goglin@...ia.fr>
Cc: "Maciej Sosnowski" <maciej.sosnowski@...el.com>,
shannon.nelson@...el.com, linux-kernel@...r.kernel.org,
net-dev@...r.kernel.org
Subject: Re: [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver
On Mon, Jul 14, 2008 at 7:17 AM, Brice Goglin <Brice.Goglin@...ia.fr> wrote:
> Maciej Sosnowski wrote:
>> Due to occasional DMA channel hangs observed for I/OAT versions 1.2 and 2.0
>> a watchdog has been introduced to check every 2 seconds
>> if all channels progress normally.
>> If stuck channel is detected, driver resets it.
>> The reset is done in two parts. The second part is scheduled
>> by the first one to reinitialize the channel after the restart.
>>
>
> Is all this transparent to the caller? Are you reposting all copies to
> the hardware after the reset? Or are we going to get some DMA_ERROR
> return values ?
>
>> Sleep time in self_test has been increased to 10ms
>> since in some cases 1ms appeared not to be enough
>
> Thanks Maciej, this helps a lot here.
>
Can I interpret this as a "Tested-by" for the watchdog and/or the self_test fix?
> Brice
Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists