linux-kernel - Re: [PATCH] tcp: do not promote SPLICE_F_NONBLOCK to socket O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080718183549.GA23263@2ka.mipt.ru>
Date:	Fri, 18 Jul 2008 22:35:50 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Octavian Purdila <opurdila@...acom.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	axboe@...nel.dk
Subject: Re: [PATCH] tcp: do not promote SPLICE_F_NONBLOCK to socket O_NONBLOCK

On Fri, Jul 18, 2008 at 09:16:43PM +0300, Octavian Purdila (opurdila@...acom.com) wrote:
> tcp_read_sock
>  ... -> skb_splice_bits -> spd_fill_page; 
>   on return (spd->nr_page is 1 and pipe->nrbufs is 1)
>  ... -> skb_splice_bits -> spd_fill_page; 
>   on return (spd->nr_page is 1 and pipe->nrbufs is 2)
>  ... -> skb_splice_bits -> spd_fill_page; 
>   on return (spd->nr_page is 1 and pipe->nrbufs is 3)
> ...
> 
> and so on until pipe->nrbufs is 16. At than point, we will block in pipe_wait, 
> inside splice_to_pipe.

Seems that SPLICE_F_NONBLOCK check should be propagated from
tcp_splice_read() into skb_splice_bits(), and this flag is actually
there already in tss.flags.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/