linux-kernel - Re: [PATCH 2/2] nfs: nfs4xdr.c do-while is not a compound statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080718190722.GA12007@fieldses.org>
Date:	Fri, 18 Jul 2008 15:07:22 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Benny Halevy <bhalevy@...asas.com>
Subject: Re: [PATCH 2/2] nfs: nfs4xdr.c do-while is not a compound statement

Thanks, applied.--b.

On Thu, Jul 17, 2008 at 09:33:04PM -0700, Harvey Harrison wrote:
> The WRITEMEM macro produces sparse warnings of the form:
> fs/nfsd/nfs4xdr.c:2668:2: warning: do-while statement is not a compound statement
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
>  fs/nfsd/nfs4xdr.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 9612d66..0957ec1 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -1162,11 +1162,11 @@ nfsd4_decode_compound(struct nfsd4_compoundargs *argp)
>  	*p++ = htonl((u32)((n) >> 32));				\
>  	*p++ = htonl((u32)(n));					\
>  } while (0)
> -#define WRITEMEM(ptr,nbytes)     do if (nbytes > 0) {		\
> +#define WRITEMEM(ptr,nbytes)     do { if (nbytes > 0) {		\
>  	*(p + XDR_QUADLEN(nbytes) -1) = 0;                      \
>  	memcpy(p, ptr, nbytes);					\
>  	p += XDR_QUADLEN(nbytes);				\
> -} while (0)
> +}} while (0)
>  #define WRITECINFO(c)		do {				\
>  	*p++ = htonl(c.atomic);					\
>  	*p++ = htonl(c.before_ctime_sec);				\
> -- 
> 1.5.6.3.569.ga9185
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/