linux-kernel - Re: [PATCH] x86: Move dma32_reserve_bootmem() after reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080718213622.GA14603@elte.hu>
Date:	Fri, 18 Jul 2008 23:36:22 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Bernhard Walle <bwalle@...e.de>
Cc:	yhlu.kernel@...il.com, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, vgoyal@...hat.com,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] x86: Move dma32_reserve_bootmem() after
	reserve_crashkernel()


* Bernhard Walle <bwalle@...e.de> wrote:

> On a x86-64 machine (nothing special I could encounter) I had the 
> problem that crashkernel reservation with the usual "64M@16M" failed. 
> While debugging that, I encountered that dma32_reserve_bootmem() 
> reserves a memory region which is in that area.
> 
> Because dma32_reserve_bootmem() does not rely on a specific offset but 
> crashkernel does, it makes sense to move the dma32_reserve_bootmem() 
> reservation down a bit. I tested that patch and it works without 
> problems. I don't see any negative effects of that move, but maybe I 
> oversaw something ...
> 
> While we strictly don't need that patch in 2.6.27 because we have the 
> automatic, dynamic offset detection, it makes sense to also include it 
> here because:
> 
>   - it's easier to get it in -stable then,
>   - many people are still used to the 'crashkernel=...@...' syntax,
>   - not everybody may be using a reloatable kernel.

applied to tip/x86/crashdump, thanks Bernhard.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/