linux-kernel - Re: [PATCH] x86: APIC: Remove apic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.55.0807182254270.12125@cliff.in.clinika.pl>
Date:	Fri, 18 Jul 2008 23:02:12 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Yinghai Lu <yhlu.kernel@...il.com>
cc:	Ingo Molnar <mingo@...e.hu>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Zachary Amsden <zach@...are.com>
Subject: Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives

On Fri, 18 Jul 2008, Yinghai Lu wrote:

>   CC      arch/x86/kernel/apic_64.o
> arch/x86/kernel/apic_64.c:170: error: unknown field 'write_atomic'
> specified in initializer
> arch/x86/kernel/apic_64.c:170: error: 'native_apic_mem_write_atomic'
> undeclared here (not in a function)
> arch/x86/kernel/apic_64.c:209: error: unknown field 'write_atomic'
> specified in initializer
> arch/x86/kernel/apic_64.c:209: warning: initialization from
> incompatible pointer type
> make[1]: *** [arch/x86/kernel/apic_64.o] Error 1
> make: *** [arch/x86/kernel] Error 2

 Just remove the offending initialisers.  They are not needed anymore as
the .write method is now used universally including places where
.write_atomic was.  I just could not stand watching the thing
proliferate...

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/