linux-kernel - Re: linux-next: Tree for July 8 (HID)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080718153732.d79f7d9f.randy.dunlap@oracle.com>
Date:	Fri, 18 Jul 2008 15:37:32 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Jiri Slaby <jslaby@...e.cz>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Pascal Terjan <pterjan@...driva.com>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for July 8 (HID)

On Wed, 9 Jul 2008 09:59:24 +0200 (CEST) Jiri Kosina wrote:

> On Tue, 8 Jul 2008, Randy Dunlap wrote:
> 
> > drivers/built-in.o: In function `usb_kbd_probe':
> > usbkbd.c:(.text+0x1457c9): undefined reference to `usbhid_lookup_quirk'
> > drivers/built-in.o: In function `usb_mouse_probe':
> > usbmouse.c:(.text+0x14603c): undefined reference to `usbhid_lookup_quirk'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> 
> This got introduced by Jiri's
> 
>  	HID: fix quirk handling in usbmouse/kbd
> 
> Added to CC (and added also Pascal).
> 
> The dependency of usbkbd/usbmouse on usbhid is strange anyway. I'd 
> probably remove the whole quirk lookup thing from usbkbd/usbmouse drivers. 
> They introduce this ugly dependency, which is not worth it I guess. Also 
> usbkbd/usbmouse drivers are not needed in the vast majority of cases 
> anyway, and they shouldn't be loaded in standard configurations at all.

Build error still present in linux-next 20080718.
Please fix it in some manner.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/