linux-kernel - [PATCH 04/06] uio: Store struct uio_mem ptr in vma->vm_private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080718050435.16250.39097.sendpatchset@rx1.opensource.se>
Date:	Fri, 18 Jul 2008 14:04:35 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Magnus Damm <magnus.damm@...il.com>, hjk@...utronix.de,
	gregkh@...e.de, akpm@...ux-foundation.org
Subject: [PATCH 04/06] uio: Store struct uio_mem ptr in vma->vm_private_data

From: Magnus Damm <damm@...l.co.jp>

Store a struct uio_mem pointer in vma->vm_private_data. This improves
performance since it allows us to remove a call to uio_find_mem()
from uio_vma_fault(). This change also moves the vma_count member from
struct uio_device to struct uio_mem.

The VM_FAULT_SIGBUS error case in uio_vma_fault() case is simply
removed since we've verified the struct uio_mem pointer earlier when
setting up the vma->vm_private_data.

Signed-off-by: Magnus Damm <damm@...l.co.jp>
---

 drivers/uio/uio.c          |   17 ++++++-----------
 include/linux/uio_driver.h |    1 +
 2 files changed, 7 insertions(+), 11 deletions(-)

--- 0004/drivers/uio/uio.c
+++ work/drivers/uio/uio.c	2008-07-18 12:43:22.000000000 +0900
@@ -32,7 +32,6 @@ struct uio_device {
 	atomic_t		event;
 	struct fasync_struct	*async_queue;
 	wait_queue_head_t	wait;
-	int			vma_count;
 	struct uio_info		*info;
 	struct kobject		*map_dir;
 };
@@ -443,25 +442,21 @@ static struct uio_mem *uio_find_mem(stru
 
 static void uio_vma_open(struct vm_area_struct *vma)
 {
-	struct uio_device *idev = vma->vm_private_data;
-	idev->vma_count++;
+	struct uio_mem *imem = vma->vm_private_data;
+	imem->vma_count++;
 }
 
 static void uio_vma_close(struct vm_area_struct *vma)
 {
-	struct uio_device *idev = vma->vm_private_data;
-	idev->vma_count--;
+	struct uio_mem *imem = vma->vm_private_data;
+	imem->vma_count--;
 }
 
 static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 {
-	struct uio_device *idev = vma->vm_private_data;
-	struct uio_mem *imem = uio_find_mem(idev, vma);
+	struct uio_mem *imem = vma->vm_private_data;
 	struct page *page;
 
-	if (!imem)
-		return VM_FAULT_SIGBUS;
-
 	if (imem->memtype == UIO_MEM_LOGICAL)
 		page = virt_to_page(imem->addr);
 	else
@@ -521,7 +516,7 @@ static int uio_mmap(struct file *filep, 
 		return ret;
 	}
 
-	vma->vm_private_data = idev;
+	vma->vm_private_data = imem;
 
 	switch (imem->memtype) {
 		case UIO_MEM_PHYS:
--- 0001/include/linux/uio_driver.h
+++ work/include/linux/uio_driver.h	2008-07-18 12:43:22.000000000 +0900
@@ -34,6 +34,7 @@ struct uio_mem {
 	int			memtype;
 	void __iomem		*internal_addr;
 	struct uio_map		*map;
+	int			vma_count;
 };
 
 #define MAX_UIO_MAPS 	5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/