linux-kernel - Re: [PATCH] Bluetooth: fix oops in rfcomm tty code (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216503500.8411.110.camel@violet.holtmann.net>
Date:	Sat, 19 Jul 2008 23:38:20 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Vegard Nossum <vegard.nossum@...il.com>
Cc:	Maxim Krasnyansky <maxk@...lcomm.com>,
	Dave Young <hidave.darkstar@...il.com>,
	Soeren Sonnenburg <kernel@....de>,
	David Woodhouse <dwmw2@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: fix oops in rfcomm tty code (v2)

Hi Vegard,

> This is a resend of a patch I sent earlier. It fixes a reproducible
> oops (see http://lkml.org/lkml/2008/7/13/89 for test case), and I'd
> be very happy for some feedback from Bluetooth people. Can this be
> included for testing somewhere? I don't have any bluetooth devices
> myself, so all my testing is limited to creating/releasing devices
> with ioctl (I'm not sure that's good enough).
> 
> Dave: I have extended the rfcomm_dev_lock to include all the setup and
> teardown of a single device. On second thought, it doesn't really make
> sense to use a separate lock for that. May I have your opinion on this
> second version? (I've fixed the comments/BUG_ON that you pointed out.)

it seems it is the actually the first time, I see this one. Anyway, so
holding that lock is a bad idea. Fixing this the right way might be
tricky since the TTY layer is involved here and own the kobject. So I
would say we have to make sure that the RFCOMM TTY will hangup when
calling RELEASEDEV or otherwise fail.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/